Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to the new Sprite Sheet dialog #28016

Merged

Conversation

YeldhamDev
Copy link
Member

  • Added option to add all frames.
  • Gave a panel styling to the ScrollContainer.
  • Moved the horizontal/vertical setters to the top and removed the space between them.
  • Removed unnecessary labels, as the dialog is self explanatory enough.

screen-2019-04-14-04-23-44

@Chaosus Chaosus added this to the 3.2 milestone Apr 14, 2019
@akien-mga akien-mga requested a review from reduz April 15, 2019 10:41
@reduz
Copy link
Member

reduz commented Apr 20, 2019

I think this could be a bit confusing. I tend to prefer linear flows on dialogs where there is only one wait to cancel and one way to confirm, but I understand the need for this. How about a button to select all frames? Something like this:

image

@YeldhamDev YeldhamDev force-pushed the spritesheet_dialog_improvements branch from 2ce9e4c to aa7d10b Compare April 21, 2019 03:33
@YeldhamDev
Copy link
Member Author

@reduz Made the changes requested, and also made it clear all selection when everything is already selected.

@akien-mga akien-mga merged commit 7018de8 into godotengine:master Apr 29, 2019
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the spritesheet_dialog_improvements branch April 29, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants